Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a bunch of reporting tasks compatible with configuration caching #20757

Merged
merged 57 commits into from
May 13, 2022

Conversation

eskatos
Copy link
Member

@eskatos eskatos commented May 12, 2022

This PR makes a bunch of reporting tasks compatible with configuration caching:

  • :dependencies
  • :buildEnvironment
  • :properties
  • :projects

This is achieved by introducing serializable intermediary reporting models and leveraging support for dependency resolution results in the configuration cache.

This fixed a lot of integration tests that rely on those tasks, hence the large number of changed files.

@eskatos eskatos added this to the 7.6 RC1 milestone May 12, 2022
@eskatos eskatos self-assigned this May 12, 2022
@eskatos eskatos force-pushed the eskatos/cc/project-report-tasks branch from b6fc476 to f191c7a Compare May 12, 2022 11:59
eskatos added 26 commits May 12, 2022 19:41
by introducing a new base class for project based report task

Signed-off-by: Paul Merlin <paul@gradle.com>
by introducing a serializable intermediary model

Signed-off-by: Paul Merlin <paul@gradle.com>
by introducing a serializable intermediary model

Signed-off-by: Paul Merlin <paul@gradle.com>
by introducing a serializable intermediary model

Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
…ionTest

Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
…egrationTest

Signed-off-by: Paul Merlin <paul@gradle.com>
…ationIntegrationTest

Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
@gradle gradle deleted a comment from eskatos May 13, 2022
I couldn't find why this was present.
The concatenaton without space also doesn't make sense.
No test seems to fail once removed.

Signed-off-by: Paul Merlin <paul@gradle.com>
@eskatos eskatos force-pushed the eskatos/cc/project-report-tasks branch from 2658687 to 67d6967 Compare May 13, 2022 07:54
@gradle gradle deleted a comment from eskatos May 13, 2022
@eskatos
Copy link
Member Author

eskatos commented May 13, 2022

@bot-gradle test this

@gradle gradle deleted a comment from eskatos May 13, 2022
@bot-gradle
Copy link
Collaborator

OK, I've already triggered the following builds for you:

@eskatos
Copy link
Member Author

eskatos commented May 13, 2022

Thank you for the review @bamboo. Please take another look

@eskatos eskatos requested a review from bamboo May 13, 2022 09:24
…tionTest

Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
by extracting explaining method

Signed-off-by: Paul Merlin <paul@gradle.com>
by tightening api visibility

Signed-off-by: Paul Merlin <paul@gradle.com>
@eskatos
Copy link
Member Author

eskatos commented May 13, 2022

@bot-gradle test and merge

@gradle gradle deleted a comment from eskatos May 13, 2022
@bot-gradle
Copy link
Collaborator

Your PR is queued. See the queue page for details.

@bot-gradle
Copy link
Collaborator

OK, I've already triggered a build for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants