Do not resolve classes dirs as a file tree

[big-guy]

This causes us to include resources in a way that causes FindBugs to
produce an annoying error message

Context

Contributor Checklist

• Review Contribution Guidelines
• Sign Gradle CLA
• Link to Design Spec for changes that affect more than 1 public API (that is, not in an internal package) or updates to > 20 files
• Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
• Provide unit tests (under <subproject>/src/test) to verify logic
• Update User Guide, DSL Reference, and Javadoc for public-facing changes
• Ensure that tests pass locally: ./gradlew quickCheck <impacted-subproject>:check

Gradle Core Team Checklist

• Verify design and implementation
• Verify test coverage and CI build status
• Verify documentation including proper use of @since and @Incubating annotations for all public APIs
• Recognize contributor in release notes

[wolfs]

Nice touch with only taking class files into account for up to date checks. I a comments regarding naming and javadocs.

[wolfs]

A javadoc would be nice here.
We have getCandidateClassFiles() on the Test task. Should we use the same name here?
Should we make this method protected so we somewhat hide it for consumers of the class?

[big-guy]

The javadoc is hidden in the diff.

But on second thought about this, I think filtering by .class files might be wrong here. I think nothing stops someone from doing something like:

findbugsMain {
   classes = files("someJar.jar")
}

And this would work. I took your advice and renamed the method and made it less visible.

[wolfs]

Nice touch with only taking class files into account for up to date checks. I added a comments regarding naming and javadocs.

[wolfs]

See my comment. I would now remove the new method completely.

[wolfs]

How is this now different to annotating getClasses directly? If we do not filter by *.class then I would actually not add this new method but just use the old method as is and only change the convention mapping.

[wolfs]

LGTM!