Collect failed tasks and report as TeamCity build problems #21352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blindpirate
force-pushed
the
blindpirate/capture-failed-tasks
branch
5 times, most recently
from
14f9517
to
2052115
Compare
blindpirate
changed the title
In the past, if code quality tasks (checkstyle/codenarc/ktlint) failed, it's a bit hard for developers to find out the problems. This PR adds a build service to collect the failed tasks and report TeamCity build problems, which can be clicked directly.
blindpirate
force-pushed
the
blindpirate/capture-failed-tasks
branch
from
2052115
to
7e5e5b7
Compare
|
@bot-gradle test this |
|
OK, I've already triggered the following builds for you: |
|
Let's try this to see if people like it. @bot-gradle test and merge |
|
OK, I've already triggered a build for you. |
ghost
approved these changes
Aug 12, 2022
ghost
mentioned this pull request
bot-gradle
added a commit
that referenced
this pull request
Aug 19, 2022
Cherry-pick #21352 to release Co-authored-by: Bo Zhang <bo@gradle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past, if code quality tasks (checkstyle/codenarc/ktlint) failed, it's a bit hard for developers to find out the problems. This PR adds a build service to collect the failed tasks and report TeamCity build problems, which can be clicked directly Example:
https://builds.gradle.org/buildConfiguration/Gradle_Master_Check_SanityCheck/54874906?buildTab=overview&expandBuildProblemsSection=true&hideProblemsFromDependencies=false&hideTestsFromDependencies=false&expandBuildChangesSection=true
Because the new code shares a lot with previous
cache-miss-monitor, a common method is extracted.