Make publishing incompatible with CC in some cases #24128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljacomet
added
in:publishing-plugins
abstratt
reviewed
Mar 2, 2023
subprojects/maven/src/main/java/org/gradle/api/publish/maven/plugins/MavenPublishPlugin.java
Outdated
Show resolved
Hide resolved
abstratt
reviewed
Mar 2, 2023
...rojects/maven/src/main/java/org/gradle/api/publish/maven/tasks/PublishToMavenRepository.java
Outdated
Show resolved
Hide resolved
ljacomet
force-pushed
the
ljacomet/gradle8/cc-detect-creds
branch
from
df3ab51
to
a014474
Compare
|
@bot-gradle test this |
|
I've triggered the following builds for you: |
When using unsafe credentials, we mark the publication task as incompatible with CC. This helps user experience instead of having weird failures on CC load. Issue #24122
ljacomet
force-pushed
the
ljacomet/gradle8/cc-detect-creds
branch
from
a014474
to
eaacb62
Compare
|
@bot-gradle test and merge |
|
I've triggered a build for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using unsafe credentials, we mark the publication task as incompatible with CC. This helps user experience instead of having weird
failures on CC load.
Issue #24122