Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn upon adding a dependency to the containing project to a detached configuration #24322

Conversation

tresat
Copy link
Member

@tresat tresat commented Mar 14, 2023

This targets a merge into #24309, see that PR first.

@tresat tresat added this to the 8.2 RC1 milestone Mar 14, 2023
@tresat tresat self-assigned this Mar 14, 2023
@tresat
Copy link
Member Author

tresat commented Mar 14, 2023

@bot-gradle test this

@bot-gradle
Copy link
Collaborator

I've triggered the following builds for you:

@tresat
Copy link
Member Author

tresat commented Mar 14, 2023

@bot-gradle test this

@gradle gradle deleted a comment from tresat Mar 14, 2023
@bot-gradle
Copy link
Collaborator

I've triggered the following builds for you:

@tresat tresat marked this pull request as ready for review March 15, 2023 11:27
@tresat tresat requested review from hythloda and a team as code owners March 15, 2023 11:27
==== Detached configurations with project dependencies

Adding a dependency on the project which contains it to a detached configuration is deprecated.
This can result in unintuitive behavior.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💭 Vague, could we add an example?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one just below.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading this again, I think maybe you meant an example of the unintuitive behavior, not the usage.

I'll see if I can add a short example.

Copy link
Member

@big-guy big-guy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if you do this today? I think this might be incomplete due to the way included builds can work.

e.g., it would be possible to have a detached configuration transitively depend on the current project.

@tresat
Copy link
Member Author

tresat commented Mar 16, 2023

After talking to Sterling about this, we've decided not to move forward with this.

We don't want to create another difference in the behavior of detached vs. regular configurations. Eventually, we need to explore the need for detached configurations at all, and if all their use cases can be better handled by regular configurations (perhaps with some additional modifications).

Some relevant issues to consider related to this:
#9894
#6881

@tresat tresat closed this Mar 16, 2023
@tresat tresat deleted the tt/82/detached-confs-with-project-deps-warn branch September 18, 2023 21:55
@ov7a ov7a removed this from the 8.2 RC1 milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants