-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn upon adding a dependency to the containing project to a detached configuration #24322
Warn upon adding a dependency to the containing project to a detached configuration #24322
Conversation
@bot-gradle test this |
I've triggered the following builds for you: |
@bot-gradle test this |
I've triggered the following builds for you: |
==== Detached configurations with project dependencies | ||
|
||
Adding a dependency on the project which contains it to a detached configuration is deprecated. | ||
This can result in unintuitive behavior. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💭 Vague, could we add an example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one just below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading this again, I think maybe you meant an example of the unintuitive behavior, not the usage.
I'll see if I can add a short example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if you do this today? I think this might be incomplete due to the way included builds can work.
e.g., it would be possible to have a detached configuration transitively depend on the current project.
After talking to Sterling about this, we've decided not to move forward with this. We don't want to create another difference in the behavior of detached vs. regular configurations. Eventually, we need to explore the need for detached configurations at all, and if all their use cases can be better handled by regular configurations (perhaps with some additional modifications). Some relevant issues to consider related to this: |
This targets a merge into #24309, see that PR first.