Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Associate each component in the dependency graph with the correct repository in build operation results #25105

Merged
merged 2 commits into from
May 18, 2023

Conversation

adammurdoch
Copy link
Member

Fixes #?

Context

Fixes the case where there are multiple identical repositories defined.

Contributor Checklist

  • Review Contribution Guidelines
  • Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
  • Provide unit tests (under <subproject>/src/test) to verify logic
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes
  • Ensure that tests pass sanity check: ./gradlew sanityCheck
  • Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest

Gradle Core Team Checklist

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation

…during graph resolution and that is specific to the graph being resolved.

This allows the graph independent state to be reused across graph resolutions, and the graph specific state to be discarded once the resolution is completed.
…ository, when there are identical repositories being used.
@adammurdoch adammurdoch added this to the 8.2 RC1 milestone May 18, 2023
@adammurdoch adammurdoch requested a review from a team as a code owner May 18, 2023 07:23
@adammurdoch adammurdoch self-assigned this May 18, 2023
@adammurdoch adammurdoch requested a review from big-guy May 18, 2023 07:23
@adammurdoch
Copy link
Member Author

@bot-gradle test and merge

@bot-gradle
Copy link
Collaborator

I've triggered a build for you.

@bot-gradle bot-gradle merged commit 47faa22 into release May 18, 2023
10 of 13 checks passed
@bot-gradle bot-gradle deleted the am/repo-names-2 branch May 18, 2023 08:18
ljacomet added a commit that referenced this pull request Jun 21, 2023
…endency graph with the correct repository in build operation results"

This reverts commit 47faa22, reversing
changes made to c307534.
ljacomet added a commit that referenced this pull request Jun 22, 2023
…endency graph with the correct repository in build operation results"

This reverts commit 47faa22, reversing
changes made to c307534.
bot-gradle added a commit that referenced this pull request Jun 22, 2023
…ments

This PR effectively reverts the following PRs:
* #25105
* #24906
* #24828

The last one seems to be the root cause for #25416 and the other 2 are built on top of it.

This is not a confirmation that the revert needs to happen but a test to see if it is possible and passes CI.

Co-authored-by: Louis Jacomet <louis@gradle.com>
@ljacomet ljacomet modified the milestones: 8.2 RC1, 8.3 RC1 Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants