Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear root metadata when extending configurations [backport] #25166

Merged
merged 1 commit into from May 31, 2023
Merged

Clear root metadata when extending configurations [backport] #25166

merged 1 commit into from May 31, 2023

Conversation

ljacomet
Copy link
Member

The hierarchy is saved as an instance variable in configuration metadata. The mutation type for configuration extension was DEPENDENCIES, which only caused the cached metadata to be reevaluated. This is not sufficient. We add a new mutation type for HIERARCHY which completely discards the metadata, allowing it to be recalculated and the new hierarchy value to be passed to the configuration metadata

@jvandort @ljacomet
Clear root metadata when extending configurations
01c153f 
The hierarchy is saved as an instance variable in configuration metadata. The mutation type for configuration extension
was DEPENDENCIES, which only caused the cached metadata to be reevaluated. This is not sufficient. We add a new mutation
type for HIERARCHY which completely discards the metadata, allowing it to be recalculated and the new hierarchy value
to be passed to the configuration metadata
@ljacomet ljacomet added this to the 7.x backport milestone May 24, 2023
@ljacomet ljacomet self-assigned this May 24, 2023
@ljacomet ljacomet requested a review from jvandort May 25, 2023 07:13
@ljacomet
Copy link
Member Author

@bot-gradle test this

@bot-gradle
Copy link
Collaborator

I've triggered the following builds for you:

jvandort
jvandort approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@jvandort jvandort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ljacomet
Copy link
Member Author

@bot-gradle test and merge

@bot-gradle
Copy link
Collaborator

WARN: The milestone of this PR is 7.x backport, but the base branch version is 7.6.2

@bot-gradle
Copy link
Collaborator

I've triggered a build for you.

@bot-gradle bot-gradle merged commit cc73181 into release7x May 31, 2023
22 checks passed
@bot-gradle bot-gradle deleted the ljacomet/gradle7x/config-hierarchy-7.6.2 branch May 31, 2023 16:01
This was referenced Jun 1, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvandort jvandort jvandort approved these changes

Assignees

@ljacomet ljacomet

Labels
None yet
Projects
None yet
Milestone
7.6.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ljacomet @bot-gradle @jvandort