Add integ test for closure-based listeners in AbstractTestTask #26210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which were not working before 8.4. Issue: #25311
abstratt
commented
Aug 29, 2023
| @@ -72,4 +72,48 @@ abstract class AbstractJUnit4TestListenerIntegrationTest extends AbstractJUnitTe | |||
| assert containsLine(result.getOutput(), "START [Test testError(SomeTest)] [testError]") | |||
| assert containsLine(result.getOutput(), "FINISH [Test testError(SomeTest)] [testError] [java.lang.RuntimeException: message]") | |||
| } | |||
|
|
|||
| def "can listen for test events using closures"() { | |||
There was a problem hiding this comment.
This now works in master, but it would fail with the CC-enabled executer in 8.3 (I applied this commit to a local copy of the release branch, and got this:
Condition not satisfied:
containsLine(result.getOutput(), "START [Test class SomeTest] [SomeTest]")
| | |
false | > Task :processTestResources NO-SOURCE
| > Task :processResources NO-SOURCE
| > Task :compileJava NO-SOURCE
| > Task :classes UP-TO-DATE
| > Task :compileTestJava
| > Task :testClasses
|
| > Task :test
|
| SomeTest > testError FAILED
| java.lang.RuntimeException at SomeTest.java:17
|
| SomeTest > testFail FAILED
| java.lang.AssertionError at SomeTest.java:15
| There were failing tests. See the report at: file:///Users/rafael/sources/gradle/trees/release/subprojects/testing-jvm/build/tmp/te%C5%9Dt%20files/JUnit4TestL.Test/t9b6w/build/reports/tests/test/index.html
|
| BUILD SUCCESSFUL in 823ms
| 2 actionable tasks: 2 executed
| Configuration cache entry stored.
<org.gradle.integtests.fixtures.executer.OutputScrapingExecutionResult@204b0f07 output=[> Task :processTestResources NO-SOURCE, > Task :processResources NO-SOURCE, > Task :compileJava NO-SOURCE, > Task :classes UP-TO-DATE, > Task :compileTestJava, > Task :testClasses, , > Task :test, , SomeTest > testError FAILED, java.lang.RuntimeException at SomeTest.java:17, , SomeTest > testFail FAILED, java.lang.AssertionError at SomeTest.java:15, There were failing tests. See the report at: file:///Users/rafael/sources/gradle/trees/release/subprojects/testing-jvm/build/tmp/te%C5%9Dt%20files/JUnit4TestL.Test/t9b6w/build/reports/tests/test/index.html, , BUILD SUCCESSFUL in 823ms, 2 actionable tasks: 2 executed, Configuration cache entry stored., ] error=[, 3 tests completed, 2 failed, ] includeBuildSrc=true mainContent=[> Task :processTestResources NO-SOURCE, > Task :processResources NO-SOURCE, > Task :compileJava NO-SOURCE, > Task :classes UP-TO-DATE, > Task :compileTestJava, > Task :testClasses, , > Task :test, , SomeTest > testError FAILED, java.lang.RuntimeException at SomeTest.java:17, , SomeTest > testFail FAILED, java.lang.AssertionError at SomeTest.java:15, There were failing tests. See the report at: file:///Users/rafael/sources/gradle/trees/release/subprojects/testing-jvm/build/tmp/te%C5%9Dt%20files/JUnit4TestL.Test/t9b6w/build/reports/tests/test/index.html, ] postBuild=[2 actionable tasks: 2 executed, Configuration cache entry stored., ] errorContent=[, 3 tests completed, 2 failed, ] groupedOutputFixture=null tasks=null>
at org.gradle.testing.junit.junit4.AbstractJUnit4TestListenerIntegrationTest.can listen for test events using closures(AbstractJUnit4TestListenerIntegrationTest.groovy:110)
There was a problem hiding this comment.
Does this mean the closure-based listeners aren't running at all? Are they broken?
There was a problem hiding this comment.
Often, yes. It was very non-deterministic. We originally tried serialize/deserialize an object tree (ListenerBroadcast) that was built up lazily.
There was a problem hiding this comment.
To be clear, we are talking about configuration cache behavior.
big-guy
approved these changes
Aug 29, 2023
|
@bot-gradle test and merge |
|
Your PR is queued. See the queue page for details. |
bot-gradle
deleted the
rchaves/master/integ-tests-for-test-task-listeners
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...which were not working before 8.4.
Issue: #25311, #25983