Append .jar extension to instrumented artifact if it doesn't have it #28460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asodja
changed the title
This was referenced Mar 14, 2024
asodja
added
a:bug
and removed
a:investigation
asodja
force-pushed
the
asodja/testkit-accessors
branch
from
5827c39
to
a297149
Compare
asodja
force-pushed
the
asodja/testkit-accessors
branch
from
a297149
to
ba5b065
Compare
asodja
changed the title
asodja
force-pushed
the
asodja/testkit-accessors
branch
from
20e63b0
to
31be8b4
Compare
mlopatkin
approved these changes
Mar 14, 2024
|
@bot-gradle test this |
|
I've triggered the following builds for you. Click here to see all build failures. |
|
@bot-gradle test and merge |
|
The merge queue build has started. Click here to see all failures if any. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add tests for generated accessors in debug mode.
So we currently instrument everything (even directories) to a jar. The problem is, that generated accessors task generates accessors only for artifacts that have .jar extension.
This is not a problem on master since we instrument directories to directoris since #28017.
Fixes #28458