Fix some IP problems in the build

[asodja]

• usage of allproject in mirrors.settings.gradle.kts script -> replaced with gradle.lifecycle.beforeProject
• accessing a BuildEnvironmentExtension on a root project -> we register now this extension to every project and wire values via gradle.lifecycle.beforeProject and a build service

[bamboo]

🤔 Before git would be executed only twice per build, right? And now it's once per project?

[asodja]

Interestingly it seems it's called 3-times in both cases during sync, at least when trying to do some println in the zip part I get for both:

> Configure project :
Executed 'git rev-parse --abbrev-ref HEAD' for ':'
Executed 'git rev-parse --abbrev-ref HEAD' for ':'
Executed 'git rev-parse --abbrev-ref HEAD' for ':'

So it looks like provider is evaulated anytime git() is called anyway, or that should not be the case?

If you have any ideas how to improve that, let me know.
We can also just merge improvement for gradle/shared-with-buildSrc/mirrors.settings.gradle.kts that is trivial and we leave this one for some other time when we'll have more tools.

[asodja]

Any thoughts if that solution could be a problem or not @gradle/bt-developer-productivity?

[blindpirate]

So it looks like provider is evaulated anytime git() is called anyway, or that should not be the case?

This seems to be expected behavior. BiProvider's implementation did run the combiner function every time:

gradle/platforms/core-configuration/model-core/src/main/java/org/gradle/api/internal/provider/AbstractMinimalProvider.java

Line 100 in 489a48f

return calculateOwnPresentValue().get();

gradle/platforms/core-configuration/model-core/src/main/java/org/gradle/api/internal/provider/BiProvider.java

Line 79 in 489a48f

R combinedUnpackedValue = combiner.apply(leftValue.getWithoutSideEffect(), rightValue.getWithoutSideEffect());

That being said, it's still a bit inefficient to have the provider instance in every Project, even though it may not be a problem right now. Suppose somebody start using gitCommitId in every Project in the future, that would be executed hundreds of times.

Right now I don't have a very good idea for this, is it possible to store the information in the similar way as DevelocityConfiguration? I think there's only one instance stored in the build right?

[bamboo]

It would be possible to always execute git once in the settings plugin and then simply propagate the data to every project as a Kotlin data class or similar construct (until we have a proper solution via the Shared Data API):

captureBuildEnvironment().let { buildEnvironment ->
  gradle.lifecycle.beforeProject {
     extensions.add("buildEnvironment", buildEnvironment)
  }
}

[asodja]

How will that affect configuration cache? E.g. will that git read be an input to configuration cache?

[bamboo]

In my example, yes. Is the git result currently directly wired as a task input or is it ever used at configuration time?

[asodja]

I think in some cases it's still used at a configuration time, but there was a PR that improved that #27954.

I was thinking that maybe a solution with a Build service could be ok in this case. So in root we would register a build service that would then cache the result of a git command, so it could be reused in other projects.

[asodja]

I think solution with BuildService works. I tested and cc is reused if commit id changes, at least for integration tests.

And if

gradle/subprojects/core-api/src/main/java/org/gradle/process/ExecOutput.java

Lines 33 to 34 in 593ea22

	* The external process is executed only once and only when the value is requested for the first
	* time.

is true, then git process should be executed just once

[blindpirate]

🚀

[bamboo]

🎉

[bamboo]

💅 Why not an interface?

[asodja]

I guess because I just copy/pasted the class. :)
Changed it to interface.

[asodja]

@bot-gradle test AST

[bot-gradle]

I've triggered the following builds for you. Click here to see all build failures.

• AllSmokeTestsPullRequestFeedback build

[asodja]

@bot-gradle test AST

[bot-gradle]

I've triggered the following builds for you. Click here to see all build failures.

• AllSmokeTestsPullRequestFeedback build