Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run ToolchainsParallelActionExecutionCrossVersionSpec with embedded executer #29149

Merged

Conversation

blindpirate
Copy link
Collaborator

ToolchainsParallelActionExecutionCrossVersionSpec has been flaky for a long time. Looking at the history, it only happens on embedded executer with TAPI current -> current execution.

It's possible that some shared state is broken by other tests in embeddedCrossVersionTest: the test itself is good, but the way we run it is wrong. This explains why it only happens with current -> current execution, because it's happening in a shared JVM.

This PR disables it for embedded executer.

@blindpirate
Copy link
Collaborator Author

@bot-gradle test qf

@bot-gradle
Copy link
Collaborator

I've triggered the following builds for you. Click here to see all build failures.

…dded executer

`ToolchainsParallelActionExecutionCrossVersionSpec` has been flaky for a few months.
Looking at the history, it only happens on embedded executer with
TAPI `current -> current` execution.

It's possible that some shared state is broken by other tests
in `embeddedCrossVersionTest`: the test itself is good, but
the way we run it is wrong.

This PR disables it for embedded executer.
@blindpirate blindpirate force-pushed the bz/flaky/ToolchainsParallelActionExecutionCrossVersionSpec branch from 4c3f11b to 84c7dc3 Compare May 15, 2024 05:31
@blindpirate
Copy link
Collaborator Author

@bot-gradle test qf

@bot-gradle
Copy link
Collaborator

I've triggered the following builds for you. Click here to see all build failures.

@blindpirate blindpirate added this pull request to the merge queue May 16, 2024
@bot-gradle bot-gradle added this to the 8.9 RC1 milestone May 16, 2024
Merged via the queue into master with commit 8220eab May 16, 2024
28 checks passed
@blindpirate blindpirate deleted the bz/flaky/ToolchainsParallelActionExecutionCrossVersionSpec branch May 16, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants