Support empty blocks for configuring functions in DCL #29158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bot-gradle test this |
|
I've triggered the following builds for you. Click here to see all build failures. |
…ons" This reverts commit cf408b8.
h0tk3y
force-pushed
the
sigushkin/declarative-dsl/empty-blocks
branch
from
b91668c
to
535bfae
Compare
|
@bot-gradle test this |
|
I've triggered the following builds for you. Click here to see all build failures. |
tresat
approved these changes
May 16, 2024
eskatos
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support optional configuring blocks for configuring functions (for now, only Kotlin functions and functions produced by custom code are eligible);
Make sure that a configuring function is invoked when Declarative data is mapped to JVM objects, even if the configuring function has an empty block or none at all;
Invoke the configuring function's JVM counterpart at most once for each receiver when mapping Declarative data to JVM objects (as opposed to an invocation per object access before, which could be even more than the number of call sites in the script).
Bonus: support applying software type functions with no configuration block, like(rolled back)softwareType()Fixes #29161