Use hostname command as fallback way of getting build host name #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- getHostName() may fail for number of reasons, for example when networking is disabled or network is down. - hostname command is a portable way of determining host name, which doesn't depend on networking to be available.
|
We're having some internal discussion on the best way to do this. Is the HOSTNAME environment variable available in your build infrastructure? |
|
No, neither |
bigdaz
pushed a commit
that referenced
this pull request
Mar 3, 2015
Use hostname command as fallback way of getting build host name
|
Merged, thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
networking is disabled or network is down.
which doesn't depend on networking to be available.
For more details, see: http://stackoverflow.com/a/7800008
For example, Fedora build servers don't have networking available, not even local loopback interface (localhost). As a result host name in Gradle build is always set to "unknown". This patch fixes the problem.