Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added org.gradle.incremental.ignoreAnnotationProcessors system property #4014

Closed

Conversation

pbi-qfs
Copy link

@pbi-qfs pbi-qfs commented Jan 11, 2018

Context

Currently, the presence of annotation processors completely disables incremental building. #3434 will improve this, but with some processors (e.g. a simple in-file replacer) this might be a complex analysis approach. This change would allow to easily specify a flag to manually enable incremental in spite the risks involved, if you know what you are doing.

Contributor Checklist

  • Review Contribution Guidelines
  • Make sure that all commmits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
  • Provide unit tests (under <subproject>/src/test) to verify logic
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes
  • Ensure that tests pass locally: ./gradlew <changed-subproject>:check

Gradle Core Team Checklist

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation
  • Recognize contributor in release notes

@oehme
Copy link
Contributor

oehme commented Jan 21, 2018

A system property is definitely not the way to model this. Please add your use case to #1320, so we can discuss it further.

@oehme oehme closed this Jan 21, 2018
@pbi-qfs
Copy link
Author

pbi-qfs commented Jan 22, 2018

Is there any prospect of having #3434 merged into master?

@oehme
Copy link
Contributor

oehme commented Jan 22, 2018

#3434 won't be merged in its current state, as the tests show that it's not working. I've taken that project over though and incremental annotation processing is my priority for Gradle 4.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants