New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GRADLE-2895 - Add support for user defined JUnit RunListeners #416
Conversation
…into junit-listener Conflicts: subprojects/plugins/src/main/groovy/org/gradle/api/internal/tasks/testing/junit/JUnitTestClassExecuter.java
It is possible to finish this merge? What is need for finishing this issue? |
We appreciate the work put into this pull request. The Gradle team doesn't currently have the capacity to deal with all of the bugs, feature requests, great ideas and pull requests that we receive. We already have a pretty big backlog, so it might take some time for us to take a look at this. Pull requests are interesting because they may seem like they come for "free". Our experience has shown that in order to maintain the level of quality and consistency that Gradle users expect, we need to invest significant engineering effort in all but the most trivial PRs. We are actively recruiting to increase our engineering team, so hopefully this is a temporary situation. We ask for patience in the meantime. |
@mtau11 In order to move forward with pull request we'll need a contributor license agreement from you. This is required for legal reasons before any code contributions can be accepted into the Gradle codebase. Would you mind signing it? |
@mtau11 Are you still interested in pushing this forward? If yes, could you sign the CLA and resolve the conflicts? |
Unfortunately if we don't get the CLA we won't be able to merge this change. If we don't hear back from @mtau11 I'll close this pull request. @pskrivanek if you are interested in starting this over the first step should be creating a design document describing the use case, implementation plan and test coverage. It can be included here: https://github.com/gradle/gradle/blob/master/design-docs/testing-improvements.md |
Hi guys, As @mtau11 is MIA, is there an alternative to load RunListener classes using gradle? I'm a bit new to gradle but handling a test listener on JUnit is something that I think is basic functionality and would be expected to be supported. |
@raulgd agree PS I can provide a patch for that. What are you guys think? |
@raulgd Great! I'll allow you to decide whether you add SPI support or not. Note that smaller changes are easier for us to review and merge, so without much context here I'll suggest you split them into 2 PRs. |
+1 |
No description provided.