GRADLE-3084 escaping of $ in unix scripts

[jscancella]

Added variable escapeMetaCharactersInDefaultJvmOpts to application plugin so that you are able to programmatically turn off the escape of the $ when creating unix run scripts. This is enabled by default, to disable and revert to old behavior set escapeMetaCharactersInDefaultJvmOpts = true in application closure

links to https://issues.gradle.org/browse/GRADLE-3084

[bmuschko]

Hi John,

Thanks for providing the pull request. You might have noticed that we are currently working on allowing to provide your own implementation of a script generator for the application plugin. That'll give users of the plugin far more flexibility with respect to

• Providing your own custom implementation of a script generator.
• Changing the default template file.

We certainly also want to allow for customizing the default script generator implementations at some point of time as provided by your pull request. Instead of exposing a way to customize the escape logic for a single meta character, we'd probably rather want to go for a more generic approach. A solution I can think of is a handler implementation that can be set for a script generator from the build script. It's implementation could contain any kind of escape logic you personally need.

I'll think of a good approach here and let you know. At the moment the code is still little bit in flux. Once it's more stable, I'll let you know.

[jscancella]

Sounds good to me! Glad to know that something even better is coming down
the line. I personally ran into these issues when converting from ant/maven
so I thought it a good place to start. Let me know if/when I can help.

On Thu, Mar 19, 2015 at 1:17 PM, Benjamin Muschko notifications@github.com
wrote:

Hi John,

Thanks for providing the pull request. You might have noticed that we are
currently working on allowing to provide your own implementation of a
script generator for the application plugin. That'll give users of the
plugin far more flexibility with respect to

• Providing your own custom implementation of a script generator.
• Changing the default template file.

We certainly also want to allow for customizing the default script
generator implementations at some point of time as provided by your pull
request. Instead of exposing a way to customize the escape logic for a
single meta character, we'd probably rather want to go for a more generic
approach. A solution I can think of is a handler implementation that can be
set for a script generator from the build script. It's implementation could
contain any kind of escape logic you personally need.

I'll think of a good approach here and let you know. At the moment the
code is still little bit in flux. Once it's more stable, I'll let you know.

—
Reply to this email directly or view it on GitHub
#422 (comment).

~John Scancella

[bmuschko]

Thanks for providing the pull request, @jscancella. In March I mentioned that we wanted to provide support for changing the default template file. The code has been released and the API has stabilized. That'll likely fix your issue though it's less straight forward than what you propose.

Unfortunately, we still haven't had the chance to find a more generalized approach for escaping metadata characters. I wrote up a spec a while ago but it's still pending a review on our end. I'll try to move this forward and let you know when we think this is right way forward. I am going to close the PR for now. Thanks again for contributing!

[johnscancella]

@bmuschko I did see the work that you all put into the new script generation and have been using it (though for me it kinda defeats the purpose of having gradle generate the script if I supply a customized one to it. But maybe that is just me).

I just looked at your spec, and it is unclear to me if the default is still the logic of escaping meta-characters? If you are still defaulting to escaping the meta-characters I would just like to add my $0.02 that I believe that to go against the spirit of gradle (sensible defaults). That is not something I would have suspected, hence why this issue was raised.

thanks for looking into this issue, and I hope that I can contribute to an accepted solution in the future.

[bmuschko]

@johnscancella

I did see the work that you all put into the new script generation and have been using it (though for me it kinda defeats the purpose of having gradle generate the script if I supply a customized one to it. But maybe that is just me).

What probably would make sense for you is to write a plugin that applies the application plugin plus any additional configuration you need e.g. custom templates so you can reuse it in multiple project.

I just looked at your spec, and it is unclear to me if the default is still the logic of escaping meta-characters?

We'd apply the same defaults we have in place at the moment. Usually we try to avoid breaking changes but give people the option of changing the defaults.