Exclude anonymous class in JUnit Platform #4774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should exclude them on the daemon side already. I don't think passing anononymous classes makes sense for any test framework. |
oehme
approved these changes
Mar 20, 2018
|
@oehme Your thoughts are exactly same as me :) |
blindpirate
force-pushed
the
blindpirate/donot-load-class
branch
2 times, most recently
from
abbb871
to
cbec130
Compare
blindpirate
force-pushed
the
blindpirate/donot-load-class
branch
from
cbec130
to
2d39c91
Compare
blindpirate
added a commit
that referenced
this pull request
Mar 22, 2018
This reverts commit abeb7eb.
blindpirate
added a commit
that referenced
this pull request
Mar 22, 2018
acourtneybrown
pushed a commit
that referenced
this pull request
Mar 22, 2018
* master: (30 commits) Fix NPE in capabilities conflict resolution By default don't render the welcome message to avoid test flakiness (#4796) Change console tests to require parallel execution only for specific tests Update user guide to reflect new plain console format Ensure console tests run with plain, rich and verbose modes Revert "Exclude anonymous class in JUnit Platform (#4774)" Add @ToBeImplemented integration tests for #4799 Always report Checkstyle violations-summary from xml report (#3901) Remove the verbose flag by default for `swiftc` Fix failing unit tests Fix test failure due to missing API export from application Fix tests and share code between C++ and Swift Wire operatingSystem into Swift binary types Remove spurious newline from tests that check output Fix issue with timeout in test Tasks that print output to the console hold it for as long as possible Up long running task timeout to 30s Create directory Fix path for Windows Create marker file to prevent rendering of initial welcome message ...
blindpirate
added a commit
that referenced
this pull request
Mar 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #4544 #4618
Previously we send anonymous class to JUnit Platform test worker, which caused some issues.
Now they're excluded by name pattern
.*\$\d+