Allowing gradle to use checkstyle 6.8+ #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
Thanks for the PR. I've added some comments, but in general it looks pretty good. |
|
Thanks for the feedback. I have made those changes. Let me know if theres anything else that needs to be done. |
| @@ -64,6 +64,20 @@ class CheckstylePluginIntegrationTest extends WellBehavedPluginTest { | |||
| file("build/reports/checkstyle/test.xml").assertContents(containsClass("org.gradle.TestClass2")) | |||
| } | |||
|
|
|||
| def "runs with checkstyle 6.8"() { | |||
|
Having given this a bit more thought, it will need some rework to ensure it works with versions of Checkstyle supplied via the |
|
Alright. I'll work towards doing it more like the PMD task. |
|
Alright, this should "just work" now |
|
Thanks Ethan. This PR has been merged and will be in Gradle 2.7. |
|
Thanks! |
|
@bigdaz can you close https://issues.gradle.org/browse/GRADLE-3314 ? |
|
Done. Thanks for the reminder. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://issues.gradle.org/browse/GRADLE-3314