Disable daemon in noDaemonTest

[blindpirate]

Context

In #6106 we disabled daemon for some certain
subprojects, however, all subprojects' noDaemonTest requires allDistribution, which
in turn invokes userguide task. This PR disabled daemon for noDaemonTest, given that
noDaemonTest is excuted once a day.

[wolfs]

I think we should do that decision in the model. I guess this time FunctionTestProject would be the way to go.
Something like
val useDaemon = subProject.useDaemon && testConfig.testType != TestType.noDaemon.

[blindpirate]

The only problem is, subProject can be null here, because

gradle/.teamcity/Gradle_Check/projects/StageProject.kt

Line 60 in 69fc4f2

buildType(FunctionalTest(model, testCoverage, stage = stage))

this line won't pass subProject parameter at all, which makes the null-handling pretty annoying. Any ideas?

[wolfs]

subProject can't be null in FunctionalTestProject:

gradle/.teamcity/Gradle_Check/projects/FunctionalTestProject.kt

Lines 16 to 32 in 69fc4f2

	model.subProjects.forEach { subProject ->
	if (shouldBeSkipped(subProject, testConfig)) {
	return@forEach
	}
	if (subProject.containsSlowTests && stage.omitsSlowProjects) {
	addMissingTestCoverage(testConfig)
	return@forEach
	}
	if (subProject.unitTests && testConfig.testType.unitTests) {
	buildType(FunctionalTest(model, testConfig, subProject.name, subProject.useDaemon, stage))
	} else if (subProject.functionalTests && testConfig.testType.functionalTests) {
	buildType(FunctionalTest(model, testConfig, subProject.name, subProject.useDaemon, stage))
	} else if (subProject.crossVersionTests && testConfig.testType.crossVersionTests) {
	buildType(FunctionalTest(model, testConfig, subProject.name, subProject.useDaemon, stage))
	}
	}

We only create the buildType(...) for soak tests - so useDaemon would be true there anyway, right?

[blindpirate]

Thanks, I also did a refactoring work to avoid some repetition.

[wolfs]

Let's not do * imports.

[wolfs]

I guess the whole if/else thing can be simplified by adding two methods to GradleSubproject:

fun hasTestsFor(type: TestType) = (unitTests && type.unitTests)
            || (functionalTests && type.functionalTests)
            || (crossVersionTests && type.crossVersionTests)

fun useDaemon(type: TestType) = useDaemon && (type != TestType.noDaemon)

Then the code simplifies to:

                        if (subProject.hasTestsOf(testConfig.testType)) {
                            buildType(FunctionalTest(model, testConfig, subProject.name, subProject.useDaemon(testConfig.testType), stage))
                        }

The we don't need this method any more.

[blindpirate]

Yeah, brilliant idea.