Add Kotlin DSL samples to Using Gradle Plugins user manual chapter #6424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
- prefer single quote strings in Groovy samples - prefer same indentation rules as other chapters Signed-off-by: Paul Merlin <paul@gradle.com>
to account for the two DSLs Signed-off-by: Paul Merlin <paul@gradle.com>
removing 'new' here and there when about the plugins {} block
it's been there for a long time now
Signed-off-by: Paul Merlin <paul@gradle.com>
also demonstrating usage of the plugins {} block in subprojects where
the plugin version was resolved in root project's plugins {} block
Signed-off-by: Paul Merlin <paul@gradle.com>
assertion that was checking a sample script exists it moved into a groovy/ subdirectory Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
eriwen
suggested changes
Aug 20, 2018
| @@ -1,7 +1,16 @@ | |||
| # tag::cli[] | |||
| # gradle build | |||
| # end::cli[] | |||
There was a problem hiding this comment.
You don't have to change it in this PR, but know that we can remove these comments from any sample config files.
| @@ -0,0 +1,34 @@ | |||
| // tag::complete-plugin-publishing[] | |||
There was a problem hiding this comment.
⭕ Doesn't seem like we need a tag here unless we intend to add a license here.
| @@ -133,25 +127,55 @@ This way of adding plugins to a project is much more than a more convenient synt | |||
|
|
|||
| This requires that plugins be specified in a way that Gradle can easily and quickly extract, before executing the rest of the build script. It also requires that the definition of plugins to use be somewhat static. | |||
|
|
|||
| There are some key differences between the new plugin mechanism and the “traditional” `apply()` method mechanism. There are also some constraints, some of which are temporary limitations while the mechanism is still being developed and some are inherent to the new approach. | |||
| There are some key differences between the `plugin {}` block mechanism and the “traditional” `apply()` method mechanism. There are also some constraints, some of which are temporary limitations while the mechanism is still being developed and some are inherent to the new approach. | |||
eriwen
added a commit
that referenced
this pull request
Aug 20, 2018
|
Branch builds passed, and I fixed the typo, squashed and merged with 280b5a5 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.