Make ReproduciblePropertiesWriter entry order independent
#8440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eskatos
requested changes
Feb 8, 2019
...dSrc/subprojects/build-base/src/main/kotlin/org/gradle/build/ReproduciblePropertiesWriter.kt
Outdated
Show resolved
Hide resolved
wolfs
reviewed
Feb 8, 2019
...dSrc/subprojects/build-base/src/main/kotlin/org/gradle/build/ReproduciblePropertiesWriter.kt
Outdated
Show resolved
Hide resolved
bamboo
force-pushed
the
bamboo/reproducible-properties
branch
from
73040de
to
8e7f59c
Compare
eskatos
approved these changes
Feb 8, 2019
buildSrc/subprojects/build/src/main/groovy/org/gradle/build/ReproduciblePropertiesWriter.groovy
Outdated
Show resolved
Hide resolved
By writing it on top of `PropertiesUtils` in order to make the parameter name index files reproducible. This commit also removes the now redundant test.
After the change to `ReproduciblePropertiesWriter` to use `PropertiesUtils` which writes the properties in order causing the classpath manifests to change.
eskatos
approved these changes
Feb 8, 2019
bamboo
force-pushed
the
bamboo/reproducible-properties
branch
from
efb17cc
to
9e2bce0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By writing it on top of
PropertiesUtilsin order to make the parameter name index files reproducible.