This repository has been archived by the owner on Aug 19, 2020. It is now read-only.
Refine messages reported to the IDE editor and their lifecycle #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by making it testable no change in behavior Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
because the IDE already provides user feedback for those. Signed-off-by: Paul Merlin <paul@gradle.com>
if location aware Signed-off-by: Paul Merlin <paul@gradle.com>
…e line number See https://youtrack.jetbrains.com/issue/KT-9766 Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
and report an error if able to reuse previous dependencies Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
by extracting explaining functions Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
and refine the 'runtime failure from current script' use case when they are disabled, the default Signed-off-by: Paul Merlin <paul@gradle.com>
|
@oehme, this should address some of your feedback |
keep errors and fatalities to TAPI failures Signed-off-by: Paul Merlin <paul@gradle.com>
Signed-off-by: Paul Merlin <paul@gradle.com>
bamboo
approved these changes
Sep 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lets text of IDE reports be simpler and actionable and also refine how failures are reported, distinguishing those happening in the currently edited script from those coming from other parts of the build logic. See the added coverage for handled cases.
To try it out:
Then import a build in IntelliJ using the Gradle installation from
./build/customThis PR also introduces support for location aware hints for build configuration runtime failures originating from the currently edited script. This feature is disabled by default and can be enabled using an internal property. There are some UX issues to iron out but this will allow us to try it out, see the added coverage.
This PR is part of #89