Skip to content
This repository has been archived by the owner on Aug 19, 2020. It is now read-only.

Let buildSrc changes be reflected in IntelliJ script editor instantly #972

Merged
merged 1 commit into from Jul 17, 2018

Conversation

eskatos
Copy link
Member

@eskatos eskatos commented Jul 17, 2018

by removing a pessimistic short-circuit in the script dependencies resolver.

See #962

intellij-gradle kts-buildsrc-change-auto-reload

Note that the above gif was recorded with Reload script dependencies on file change enabled. This PR also applies to when it's not.

Also note that with IntelliJ Kotlin Plugin <=1.2.60-eap-44 you need to explicitly save for it to work. A fix is in the works so that changing focus is enough.

Signed-off-by: Paul Merlin <paul@gradle.com>
Copy link
Contributor

@JLLeitschuh JLLeitschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wooooo! This will be awesome!

I notice a lot of tests removed, are there any tests that should be added to cover this change?

@eskatos
Copy link
Member Author

eskatos commented Jul 17, 2018

@JLLeitschuh the removed test was asserting the now removed short-circuit.

@eskatos eskatos merged commit 5c39c87 into develop Jul 17, 2018
@eskatos eskatos deleted the eskatos/intellij-resolver/remove-short-circuit branch July 17, 2018 15:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants