Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for running on ARM64 Windows #318

Merged
merged 2 commits into from
Jun 19, 2023

Conversation

modmuss50
Copy link
Contributor

@modmuss50 modmuss50 commented Aug 31, 2022

Hello 馃憢,

This PR is a big step forward in supporting ARM64 Windows.

Depends on: gradle/gradle#21780
Major step forward for: gradle/gradle#21703

Screenshot of the native-platform-test application running:
image

This will require the ARM64 compiler to be installed using the Visual Studio installer, I find this is not usually included by default. This has currently only been tested using the test application, and not "end-to-end" in a full Gradle project.

I look forward to any questions or feedback 馃憤

Signed-off-by: modmuss50 modmuss50@gmail.com

Signed-off-by: modmuss50 <modmuss50@gmail.com>
@chadlwilson
Copy link

Possibly related to #274 (although not sure if it specifically fixes the WindowsRegistry is not supported on this operating system blocker for tool chains support).

@modmuss50 modmuss50 marked this pull request as ready for review January 11, 2023 12:07
@modmuss50
Copy link
Contributor Author

This PR should be ready for review now that gradle/gradle#21780 was merged, however I think a maintainer needs to finish it off.

  • native-platform needs updating to Gradle 8 and the latest nightly, I'm struggling with this.
  • The build machines will need the Visual Studio ARM64 components installed.
  • After merging native-platform needs updating in Gradle.

This will fix the WindowsRegistry is not supported on this operating system when running on ARM64.

@imkiva
Copy link

imkiva commented Mar 16, 2023

Hi maintainers, is there any plan for merging this PR? I met this problem today when I was trying to setup my Windows on ARM developer kit. Or is that possible to bypass this restriction through some configurable settings in gradle.properties? I know one use case of windows registry is to detect installed JDKs but I am not sure if it is used elsewhere.

@imkiva
Copy link

imkiva commented Mar 19, 2023

Maybe it is necessary to upgrade the Gradle wrapper version to 7.6.1 or higher since it contains the gradle/gradle#21780 needed by this patch.
Update: I just tried locally, and found the required patch is not in Gradle 8.0 but 8.2.

imkiva pushed a commit to imkiva/native-platform that referenced this pull request Mar 19, 2023
@big-guy big-guy added this to the 8.2 RC1 milestone Mar 23, 2023
@big-guy big-guy modified the milestones: 8.2 RC1, 8.3 RC1 Apr 6, 2023
@big-guy big-guy merged commit 1daadb3 into gradle:master Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants