Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: getaddrinfo ENOTFOUND downloads.gradle-dn.com #33

Closed
jaredsburrows opened this issue Nov 18, 2020 · 11 comments · Fixed by #39
Closed

Error: getaddrinfo ENOTFOUND downloads.gradle-dn.com #33

jaredsburrows opened this issue Nov 18, 2020 · 11 comments · Fixed by #39

Comments

@jaredsburrows
Copy link

Example:
https://github.com/jaredsburrows/android-gif-example/pull/133/checks?check_run_id=1419386504

Error:

Run gradle/wrapper-validation-action@v1
Error: getaddrinfo ENOTFOUND downloads.gradle-dn.com
@JLLeitschuh
Copy link
Contributor

@jaredsburrows can you link to a specific line?

@JLLeitschuh
Copy link
Contributor

That looks like a DNS lookup failure. 'downloads.gradle-dn.com' is a DNS record configured through cloudflare. I wish we had a better stack trace here. This is probably happening just because the HTTP library that the GH action uses under the hood doesn't retry DNS lookups. Maybe we should do our own retrying in our code. @eskatos thoughts?

@JLLeitschuh
Copy link
Contributor

@jaredsburrows is this the first time you've ever seen this?

@jaredsburrows
Copy link
Author

Yes. I am wondering if it was some fluke. Like maybe there was not internet or something?

@JLLeitschuh
Copy link
Contributor

Sounds like this is a transient DNS lookup failure issue. Simple fix is more robust retry, I think.

@eskatos
Copy link
Member

eskatos commented Nov 19, 2020

I think that adding a retry wouldn't hurt given we only do idempotent requests.
Let's see if we get more reports before taking action.

@simonbasle
Copy link

not entirely the same, but I got Error: connect ETIMEDOUT 104.17.160.20:443 today... that one might be less transient than a DNS lookup failure though, so not sure retry would have helped anyway

@JLLeitschuh
Copy link
Contributor

JLLeitschuh commented Dec 2, 2020

Yea, so I think this is a sign we need to put in some retry logic. Thanks for the comment.

@KengoTODA
Copy link
Contributor

Hope that this issue has been resolved by #39

@JLLeitschuh
Copy link
Contributor

Closed by #39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants