-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error: getaddrinfo ENOTFOUND downloads.gradle-dn.com #33
Comments
@jaredsburrows can you link to a specific line? |
That looks like a DNS lookup failure. 'downloads.gradle-dn.com' is a DNS record configured through cloudflare. I wish we had a better stack trace here. This is probably happening just because the HTTP library that the GH action uses under the hood doesn't retry DNS lookups. Maybe we should do our own retrying in our code. @eskatos thoughts? |
@jaredsburrows is this the first time you've ever seen this? |
Yes. I am wondering if it was some fluke. Like maybe there was not internet or something? |
Sounds like this is a transient DNS lookup failure issue. Simple fix is more robust retry, I think. |
I think that adding a retry wouldn't hurt given we only do idempotent requests. |
not entirely the same, but I got |
Yea, so I think this is a sign we need to put in some retry logic. Thanks for the comment. |
Hope that this issue has been resolved by #39 |
Closed by #39 |
Example:
https://github.com/jaredsburrows/android-gif-example/pull/133/checks?check_run_id=1419386504
Error:
The text was updated successfully, but these errors were encountered: