-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update known wrapper checksums #175
Conversation
@bigdaz, I am not completely sure why it picked you as author of the generated commit. Maybe because you merged the original changes and are now considered the person who triggered the scheduled workflow. If that is not desired because it could cause confusion, we could edit the workflow and specify a different author, for example the GitHub bot account. |
@Marcono1234 One downside of loading the JSON as a module is that we need to rebuild Ideally, we'd come up with some sort of "test-and-merge" workflow that would:
|
This could probably be solved by letting the GitHub workflow not only update
Do you mean this should be executed right before the merge? I am not sure if that will be possible, since the Maybe the approach of having a workflow for the |
Yes, please. That would be excellent.
This is what I meant. I think it could work as long as we require that all contributed PRs have "Allow edits and access to secrets by maintainers" checked.
Yes, this could be really nice. |
@bigdaz, I have been thinking a bit more about this. Maybe the workflow for updating My suggestion to use What could work is copying the
|
Have created a proof of concept here: #187 |
Automatically generated pull request to update the known wrapper checksums.
In case of conflicts, manually run the workflow from the Actions tab, the changes will then be force-pushed onto this pull request branch.
Do not manually update the pull request branch; those changes might get overwritten.
Important
GitHub workflows have not been executed for this pull request yet. Before merging, close and then directly reopen this pull request to trigger the workflows.