Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tensorboard callbacks #173

Merged
merged 6 commits into from
Jan 30, 2022
Merged

Tensorboard callbacks #173

merged 6 commits into from
Jan 30, 2022

Conversation

arv-77
Copy link
Contributor

@arv-77 arv-77 commented Jan 24, 2022 •
edited by aniketmaurya

Changes

Fixes #123

Type of change

  • 📚 Documentation Update
  • 🧪 Tests Cases
  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔬 New feature (non-breaking change which adds functionality)
  • 🚨 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Did you update CHANGELOG (docs/CHANGELOG.md) in case of a major change?

Solves issue #123
I have added basic tensorboard callback functionality which include: logging the loss and accuracy for both training and validation.
Is there any other functionality of tensorboard that I need to add @aniketmaurya

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 24, 2022
github-actions[bot]
github-actions bot reviewed Jan 24, 2022
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @arvindmuralie77! Thank you for opening your first pull request in this repo. We are so happy that you have decided to contribute and value your contribution. Please read these materials before proceeding: Contributing Guide and Code of Conduct.

@codecov
Copy link

codecov bot commented Jan 24, 2022 •
edited

Codecov Report

Merging #173 (5a92610) into main (d6ec5bc) will decrease coverage by 1.76%.
The diff coverage is 26.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #173      +/-   ##
==========================================
- Coverage   96.75%   94.99%   -1.77%     
==========================================
  Files          68       69       +1     
  Lines        2064     2117      +53     
==========================================
+ Hits         1997     2011      +14     
- Misses         67      106      +39
Flag Coverage Δ
unittests 94.99% <26.41%> (-1.77%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gradsflow/callbacks/tensorboard.py 25.00% <25.00%> (ø)
gradsflow/callbacks/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6ec5bc...5a92610. Read the comment docs.

@aniketmaurya
Copy link
Contributor

aniketmaurya commented Jan 24, 2022 •
edited

@arvindmuralie77 awesome work, feel free to set the PR for review when you're ready.

@arv-77 arv-77 marked this pull request as ready for review January 24, 2022 17:00
@arv-77
Copy link
Contributor Author

arv-77 commented Jan 25, 2022

@aniketmaurya set the PR as ready for review

@aniketmaurya
Copy link
Contributor

@aniketmaurya set the PR as ready for review

Looks good! Do wanna add logging for step_loss as well in this PR or maybe a next PR?

@arv-77
Copy link
Contributor Author

arv-77 commented Jan 25, 2022

Sure I'll add step_loss in this PR

@arv-77
Copy link
Contributor Author

arv-77 commented Jan 25, 2022

Hey, @aniketmaurya should I also plot the metrics for every step epoch?

@aniketmaurya
Copy link
Contributor

Hey, @aniketmaurya should I also plot the metrics for every step epoch?

Sure, let's log metrics for every train_step

@aniketmaurya
Copy link
Contributor

aniketmaurya commented Jan 25, 2022 •
edited

You can check to the Wandb callback for reference.

@aniketmaurya aniketmaurya added enhancement New feature or request and removed documentation Improvements or additions to documentation labels Jan 25, 2022
@aniketmaurya aniketmaurya linked an issue Jan 25, 2022 that may be closed by this pull request
Tensorboard callback #123
Closed
@aniketmaurya aniketmaurya self-requested a review January 25, 2022 20:31
aniketmaurya
aniketmaurya approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@aniketmaurya aniketmaurya left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thanks for your contribution 🎉

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 28, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jan 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@arv-77
Copy link
Contributor Author

arv-77 commented Jan 28, 2022 •
edited

@aniketmaurya added functionality for plotting metrics and loss for every step_loss as well

aniketmaurya
aniketmaurya approved these changes Jan 30, 2022
View reviewed changes
Copy link
Contributor

@aniketmaurya aniketmaurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Let's merge this now.

@aniketmaurya aniketmaurya merged commit 84fb252 into gradsflow:main Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions github-actions left review comments

@aniketmaurya aniketmaurya aniketmaurya approved these changes

Assignees

@arv-77 arv-77

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tensorboard callback
2 participants
@arv-77 @aniketmaurya