[refactor minor] nodejitsu-api returns integer status codes

gradus · Jun 28, 2012 · 2d9cf58 · 2d9cf58
1 parent 0945208
commit 2d9cf58
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/lib/jitsu.js b/lib/jitsu.js
@@ -264,10 +264,10 @@ jitsu.showError = function (command, err, shallow, skip) {
   var username,
       stack;
 
-  if (err.statusCode === '403') {
+  if (err.statusCode === 403) {
     //jitsu.log.error('403 ' + err.result.error);
   }
-  else if (err.statusCode === '503') {
+  else if (err.statusCode === 503) {
     if (err.result && err.result.message) {
       jitsu.log.error(err.result.message);
     }

diff --git a/lib/jitsu/commands/apps.js b/lib/jitsu/commands/apps.js
@@ -286,7 +286,7 @@ apps.list = function (username, callback) {
 
   jitsu.apps.list(username, function (err, apps) {
     if (err) {
-      if (err.statusCode === "403") {
+      if (err.statusCode === 403) {
         jitsu.log.error(jitsu.config.get('username').magenta + ' is not authorized to list applications for user: ' + username.magenta);
       }
       return callback(err);

diff --git a/lib/jitsu/commands/databases.js b/lib/jitsu/commands/databases.js
@@ -79,7 +79,7 @@ databases.create = function (requestedDatabaseType, requestedDatabaseName, callb
         //
         // TODO: Refactor this error handling
         //
-        if (err && err.statusCode === '409' || err.statusCode === '404') {
+        if (err && err.statusCode === 409 || err.statusCode === 404) {
           jitsu.log.error('Database with name ' + database.name.magenta + ' already exists');
           jitsu.log.info('Try again with a new database name');
           database.name = null;
@@ -152,7 +152,7 @@ databases.get = function (databaseName, callback) {
 
   jitsu.databases.get(databaseName, function (err, results) {
     if (err) {
-      if (err.statusCode === '404') {
+      if (err.statusCode === 404) {
         jitsu.log.error('Database does not exist');
       }
       else {

diff --git a/lib/jitsu/commands/snapshots.js b/lib/jitsu/commands/snapshots.js
@@ -178,7 +178,7 @@ snapshots.activate = function (name, callback) {
         //
         // Remark: The nodejitsu API should probably be returning a 404 here and not a 400
         //
-        if(err.statusCode === "400") {
+        if(err.statusCode === 400) {
           jitsu.log.error('Application ' + name.magenta + ' not found.');
         }
         return callback(err);