Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRAFANA_TOKEN env variable is not passed correctly #16

Open
julialau23 opened this issue Jun 14, 2024 · 3 comments
Open

GRAFANA_TOKEN env variable is not passed correctly #16

julialau23 opened this issue Jun 14, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@julialau23
Copy link

When the Grafana class is initialized in grafana.py, there is only a check for the "url" field in the parameters. If the GRAFANA_TOKEN env variable is set, the token is never passed to the GrafanaApi client and therefore results in a GrafanaUnauthorizedError when making requests using grafana_client. A credential field needs to be added to the from_url call to populate the GRAFANA_TOKEN env variable.

@amotl
Copy link
Contributor

amotl commented Jul 3, 2024

Dear @julialau23. Thanks a stack for the report. May we ask if you would have the capacities to submit a patch?

@amotl amotl self-assigned this Jul 3, 2024
@amotl amotl added the bug Something isn't working label Jul 3, 2024
@julialau23
Copy link
Author

julialau23 commented Jul 10, 2024 via email

@amotl
Copy link
Contributor

amotl commented Jul 11, 2024

Hi @julialau23. Thanks a stack. You can easily fork the repository, and then submit a pull request, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants