SQLite cache: Use SQLite write-ahead logging for better concurrency #136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
@edgarasg reported there is still a problem with the SQLite-based cache and concurrent access.
Solution
@JWCook informed us about the
wal=True
argument to requests-cache' Session class/mixin, effectively enabling SQLite write-ahead logging, allowing read operations to not block writes.[1] https://sqlite.org/wal.html