Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Go 1.19 #1983

Closed
andig opened this issue Aug 3, 2022 · 1 comment · Fixed by #1985
Closed

Support Go 1.19 #1983

andig opened this issue Aug 3, 2022 · 1 comment · Fixed by #1985
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.

Comments

@andig
Copy link

andig commented Aug 3, 2022

Homebrew/homebrew-core#107165 fails due to

panic: Something in this program imports go4.org/unsafe/assume-no-moving-gc to declare that it assumes a non-moving garbage collector, but your version of go4.org/unsafe/assume-no-moving-gc hasn't been updated to assert that it's safe against the go1.19 runtime. If you want to risk it, run with environment variable ASSUME_NO_MOVING_GC_UNSAFE_RISK_IT_WITH=go1.19 set. Notably, if go1.19 adds a moving garbage collector, this program is unsafe to use.

This can be fixed by upgrading go4.org/unsafe/assume-no-moving-gc according to quic-go/quic-go#3491

rfratto added a commit to rfratto/agent that referenced this issue Aug 3, 2022
@rfratto
Copy link
Member

rfratto commented Aug 3, 2022

Thanks, #1985 should take care of this. Will this block updating the Go formula to 1.19? We typically release a new version of Grafana Agent every six weeks, but we can figure something out if this is needed urgently.

rfratto added a commit that referenced this issue Aug 3, 2022
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants