Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Loki/Promtail support #125

Merged
merged 10 commits into from Aug 12, 2020
Merged

Initial Loki/Promtail support #125

merged 10 commits into from Aug 12, 2020

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Jun 24, 2020

This PR introduces support for embedding Loki (promtail) into the Agent. This required bumping up some of our dependencies to the versions that Loki uses and changing some of the code for everything to compile again. I've also had to switch the Docker image to a debian:stretch-slim base for libsystemd.

This PR also removes the conditionals around whether CGO should be enabled and just always enables it. Promtail needs CGO for journald on Linux, which also means every platform except for Windows now needs CGO for something and we're not gaining anything by conditionally enabling CGO.

TODO:

  • cry about replace directives in go.mod
  • upstream changes to make embedding a little cleaner
  • Clean up flags
  • Make lint/test pass
  • docs? (or just link to existing Promtail docs)

@rfratto
Copy link
Member Author

rfratto commented Aug 11, 2020

Making this as review for review since everything is done with the exception of documentation.

@rfratto rfratto marked this pull request as ready for review August 11, 2020 18:07
@rfratto rfratto changed the title wip: loki/promtail support Loki/Promtail support Aug 11, 2020
@rfratto
Copy link
Member Author

rfratto commented Aug 11, 2020

I've added libsystemd-dev to rfratto/seego so the release builds will work with Promtail support.

@rfratto rfratto changed the title Loki/Promtail support Initial Loki/Promtail support Aug 12, 2020
Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loki doki

@rfratto rfratto merged commit a2644cf into grafana:master Aug 12, 2020
@rfratto rfratto deleted the promtail branch August 12, 2020 16:53
mattdurham pushed a commit that referenced this pull request Nov 11, 2021
* wip: promtail support

* bump to latest loki

* update to latest loki (again)

* loki: prefixed flags, custom logger

* see go CGO

* see go pass lint and test

* libsystemd for CI and Dockerfile

* go mod tidy

* force procfs version to initial version embedded to retain FreeBSD support

* add links to documentation on promtail
wildum pushed a commit that referenced this pull request Apr 9, 2024
* Clean up beyla topic

* General syntax cleanup

* Update pyroscope sytnax and style
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label May 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants