Update flags used for metrics #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WAL directory for metrics will now default to the same directory as Prometheus Agent (i.e., `data-agent/`)
zimbatm
pushed a commit
to NixOS/nixpkgs
that referenced
this pull request
Jun 19, 2022
…rics` According to grafana/agent#1540, -prometheus.* flages were deprecated in 0.19.0 in favor of the -metrics.* counterparts. Same applies to `loki` being renamed to `logs`. I'm not sure if the config file format is still supported (it could be), but we shouldn't use deprecated configs.
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR contains a number of small changes:
-prometheus.*flags in favor of their-metrics.*counterparts.-prometheus.*flags were first deprecated in v0.19.0.-metrics.service..instead of-metrics.service.(two dots instead of the intended one).data-agent/, which is the same default value Prometheus Agent uses.Which issue(s) this PR fixes
N/A
Notes to the Reviewer
PR Checklist