Metric Working Group #1814
Merged
Metric Working Group #1814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdurham
commented
Jun 22, 2022
mattdurham
commented
Jun 22, 2022
mattdurham
commented
Jun 22, 2022
mattdurham
commented
Jun 22, 2022
mattdurham
commented
Jun 22, 2022
mattdurham
commented
Jun 22, 2022
mattdurham
commented
Jun 22, 2022
mattdurham
commented
Jun 22, 2022
mattdurham
commented
Jun 22, 2022
tpaschalis
reviewed
Jun 23, 2022
mattdurham
commented
Jun 23, 2022
tpaschalis
reviewed
Jun 24, 2022
# Conflicts: # cmd/agentflow/basic_scraper.flow
tpaschalis
reviewed
Jul 5, 2022
tpaschalis
reviewed
Jul 5, 2022
tpaschalis
approved these changes
Jul 6, 2022
There was a problem hiding this comment.
LGTM. I'm basing the scraping component over at #1850 on this, let's get more of the puzzle pieces together ^^
This was referenced Jul 14, 2022
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
PR to add Metrics/Appender to Flow. Consider the remote_write and scraping components proof of concept to show the workings of the communication between components. Primarily reviewing the receiver/appendable/globalref mapping. The scraper and remote_write are just there to show how the receiver/appendable/globalref work and will likely be redone later.