Fix issue where the in-memory dialer was not being passed to modules. #4044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfratto
reviewed
Jun 2, 2023
captncraig
pushed a commit
that referenced
this pull request
Jun 2, 2023
…#4044) * Fix issue where the in-memory dialer was not being passed to modules. * Fix type * Fix location of changelog
captncraig
added a commit
that referenced
this pull request
Jun 2, 2023
* Fix issue where the in-memory dialer was not being passed to modules. (#4044) * Fix issue where the in-memory dialer was not being passed to modules. * Fix type * Fix location of changelog * update references for v0.34.0-rc.1 (#4047) * fix changelog for 0.34.0-rc.1 --------- Co-authored-by: mattdurham <mattdurham@ppog.org>
clayton-cornell
pushed a commit
that referenced
this pull request
Aug 14, 2023
…#4044) * Fix issue where the in-memory dialer was not being passed to modules. * Fix type * Fix location of changelog
clayton-cornell
pushed a commit
that referenced
this pull request
Aug 14, 2023
…#4044) * Fix issue where the in-memory dialer was not being passed to modules. * Fix type * Fix location of changelog
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
The dialerfunc is not being passed to the child modules, this caused exporters to fail since they were exporting agent.internal but serving on normal http.
PR Checklist