New component: discovery.puppetdb #4551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
marctc
reviewed
Jul 24, 2023
|
|
||
| ```river | ||
| discovery.puppetdb "example" { | ||
| url = "http://puppetdb.local:8080" |
There was a problem hiding this comment.
@captncraig could you apply riverfmt to this snippet?
marctc
reviewed
Jul 25, 2023
| @@ -0,0 +1,49 @@ | |||
| package puppetdb | |||
There was a problem hiding this comment.
should we add tests for validate functions?
marctc
reviewed
Aug 8, 2023
Co-authored-by: Marc Tudurí <marctc@protonmail.com>
marctc
approved these changes
Aug 8, 2023
clayton-cornell
added a commit
that referenced
this pull request
Aug 14, 2023
* discovery.puppetdb * docs * fix example * fix comment * Update docs/sources/flow/reference/components/discovery.puppetdb.md Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com> * Update docs/sources/flow/reference/components/discovery.puppetdb.md Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com> * add test for validate * Update docs/sources/flow/reference/components/discovery.puppetdb.md Co-authored-by: Marc Tudurí <marctc@protonmail.com> * lint --------- Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com> Co-authored-by: Marc Tudurí <marctc@protonmail.com>
clayton-cornell
added a commit
that referenced
this pull request
Aug 14, 2023
* discovery.puppetdb * docs * fix example * fix comment * Update docs/sources/flow/reference/components/discovery.puppetdb.md Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com> * Update docs/sources/flow/reference/components/discovery.puppetdb.md Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com> * add test for validate * Update docs/sources/flow/reference/components/discovery.puppetdb.md Co-authored-by: Marc Tudurí <marctc@protonmail.com> * lint --------- Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com> Co-authored-by: Marc Tudurí <marctc@protonmail.com>
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2279