Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(dep): remove obsolete go mod replace for perflib_exporter #5925

Merged
merged 5 commits into from
Jan 9, 2024

Conversation

hainenber
Copy link
Contributor

PR Description

perflib_exporter usage was deprecated since #5784 and the PR in the replace's comment was merged to upstream in v0.24.0, therefore this can be safely removed.

Which issue(s) this PR fixes

N/A

Notes to the Reviewer

PR Checklist

N/A

Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber hainenber force-pushed the remove-perflib-go-mod-replacement branch from d5e5feb to e71b3fe Compare December 6, 2023 15:41
Copy link
Collaborator

@mattdurham mattdurham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marctc marctc enabled auto-merge (squash) January 5, 2024 10:45
@marctc marctc merged commit e648031 into grafana:main Jan 9, 2024
2 checks passed
@hainenber hainenber deleted the remove-perflib-go-mod-replacement branch January 9, 2024 14:11
BarunKGP pushed a commit to BarunKGP/grafana-agent that referenced this pull request Feb 20, 2024
Signed-off-by: hainenber <dotronghai96@gmail.com>
Co-authored-by: mattdurham <mattdurham@ppog.org>
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants