Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce agentctl #60

Merged
merged 10 commits into from
May 11, 2020
Merged

Introduce agentctl #60

merged 10 commits into from
May 11, 2020

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented May 8, 2020

agentctl is a new tool that will be used for tasks for interacting with the Agent API. Currently, it only implements one subcommand, config-sync, that uses the YAML contents of a directory as a source-of-truth for what should exist on the config management API.

Blocked by #53. Do not merge until the target branch is master and #53 is merged.

Blocked by the grafana/agentctl image repository existing, which it doesn't yet.

@rfratto rfratto marked this pull request as draft May 8, 2020 17:25
@rfratto rfratto changed the base branch from master to cluster-agents May 8, 2020 18:35
@rfratto rfratto marked this pull request as ready for review May 8, 2020 18:35
@rfratto rfratto requested a review from hoenn May 8, 2020 18:36
docs/scraping-service.md Outdated Show resolved Hide resolved
cmd/agent/main.go Outdated Show resolved Hide resolved
@rfratto rfratto changed the base branch from cluster-agents to master May 8, 2020 19:44
Copy link
Contributor

@gotjosh gotjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loving your work! All my comments are optional feel free to pick and choose but def don't need to resolve any for merging.

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
docs/scraping-service.md Outdated Show resolved Hide resolved
pkg/agentctl/sync.go Outdated Show resolved Hide resolved
pkg/agentctl/sync.go Outdated Show resolved Hide resolved
cmd/agentctl/main.go Show resolved Hide resolved
pkg/client/client.go Show resolved Hide resolved
rfratto and others added 3 commits May 11, 2020 06:11
Co-authored-by: gotjosh <josue.abreu@gmail.com>
Co-authored-by: gotjosh <josue.abreu@gmail.com>
Copy link
Contributor

@gotjosh gotjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rfratto rfratto merged commit c54d2c4 into grafana:master May 11, 2020
@rfratto rfratto deleted the agentctl branch May 11, 2020 13:28
mattdurham pushed a commit that referenced this pull request Nov 11, 2021
* cmd/agentctl: initial commit

* pkg/client: add client for agent http/1 API

* implement agentctl and hook up to CI for builds

* fix test fail

* address review feedback

* agentctl: exit with failure when config-sync fails

* Update docs/scraping-service.md

Co-authored-by: gotjosh <josue.abreu@gmail.com>

* Update pkg/agentctl/sync.go

Co-authored-by: gotjosh <josue.abreu@gmail.com>

* address review feedback

* return error at the end of syncing if anything failed

Co-authored-by: gotjosh <josue.abreu@gmail.com>
wildum pushed a commit that referenced this pull request Apr 9, 2024
Use common secret GITHUB_TOKEN for backport jobs. This means that
backports will be done by the github-actions bot instead of grafanabot,
but the backport job will work properly.

I verified this works by looking at grafana/tempo, which uses
GITHUB_TOKEN instead of a grafanabot API token.
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label May 4, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants