-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce agentctl
#60
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoenn
reviewed
May 8, 2020
hoenn
reviewed
May 8, 2020
hoenn
approved these changes
May 8, 2020
gotjosh
approved these changes
May 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loving your work! All my comments are optional feel free to pick and choose but def don't need to resolve any for merging.
Co-authored-by: gotjosh <josue.abreu@gmail.com>
Co-authored-by: gotjosh <josue.abreu@gmail.com>
gotjosh
approved these changes
May 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mattdurham
pushed a commit
that referenced
this pull request
Nov 11, 2021
* cmd/agentctl: initial commit * pkg/client: add client for agent http/1 API * implement agentctl and hook up to CI for builds * fix test fail * address review feedback * agentctl: exit with failure when config-sync fails * Update docs/scraping-service.md Co-authored-by: gotjosh <josue.abreu@gmail.com> * Update pkg/agentctl/sync.go Co-authored-by: gotjosh <josue.abreu@gmail.com> * address review feedback * return error at the end of syncing if anything failed Co-authored-by: gotjosh <josue.abreu@gmail.com>
wildum
pushed a commit
that referenced
this pull request
Apr 9, 2024
Use common secret GITHUB_TOKEN for backport jobs. This means that backports will be done by the github-actions bot instead of grafanabot, but the backport job will work properly. I verified this works by looking at grafana/tempo, which uses GITHUB_TOKEN instead of a grafanabot API token.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
frozen-due-to-age
Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
agentctl
is a new tool that will be used for tasks for interacting with the Agent API. Currently, it only implements one subcommand,config-sync
, that uses the YAML contents of a directory as a source-of-truth for what should exist on the config management API.Blocked by #53. Do not merge until the target branch is
master
and #53 is merged.Blocked by the
grafana/agentctl
image repository existing, which it doesn't yet.