fix(pyroscope.java): infer service_name label if possible #6184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korniltsev
commented
Jan 29, 2024
|
@clayton-cornell @knylander-grafana ptal at docs when you have time |
clayton-cornell
added
the
type/docs
clayton-cornell
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
@korniltsev Docs are fine as-is. It matches lang and style of existing content.
BarunKGP
pushed a commit
to BarunKGP/grafana-agent
that referenced
this pull request
Feb 20, 2024
* fix(pyroscope.java): infer service_name label if possible * Do not mutate target * update changelog, fix scrape infer * fix * fix
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
pyroscope.javacomponent inferservice_namelabel similar topyroscope.scrapeandpyroscope.ebpfpyroscope.scrapeto use dockerswarm labels forservice_nameinferWhich issue(s) this PR fixes
Notes to the Reviewer
PR Checklist