Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyroscope: change demangle default value from none to full #6191

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

petethepig
Copy link
Member

@petethepig petethepig requested a review from a team as a code owner January 18, 2024 21:24
Copy link
Contributor

@korniltsev korniltsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made it none by default as a premature optimization.

I dont like changing it to full as current implementation will process each symbol even when we dont need any processing, even if it is golang or python.

For example grafana workloads doe not need this default.

@korniltsev
Copy link
Contributor

You probably need to update changlog

@korniltsev
Copy link
Contributor

Other things to consider in the future:

  • demangling should be done only for C++/Rust. currently it is done for all
  • It can happen on the storage side at distributor or maybe query

@korniltsev
Copy link
Contributor

You probably need to update docs with the new default

Copy link
Contributor

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@github-actions github-actions bot added the needs-attention An issue or PR has been sitting around and needs attention. label Feb 22, 2024
@rfratto rfratto added variant/flow Relatd to Grafana Agent Flow. enhancement New feature or request labels Apr 9, 2024
@github-actions github-actions bot removed the needs-attention An issue or PR has been sitting around and needs attention. label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request variant/flow Relatd to Grafana Agent Flow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants