Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move git logic from internal in modules to internal in agent #6211

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

wildum
Copy link
Contributor

@wildum wildum commented Jan 22, 2024

PR Description

Move internal git logic from the modules folder to the internal package of the agent. The import git node will have the possibility to reuse this logic in the upcoming new modules feature. (#5968)

@wildum wildum marked this pull request as ready for review January 22, 2024 09:39
Copy link
Member

@tpaschalis tpaschalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thampiotr thampiotr merged commit 5087810 into main Jan 22, 2024
10 checks passed
@thampiotr thampiotr deleted the refactor-git-modules branch January 22, 2024 11:37
BarunKGP pushed a commit to BarunKGP/grafana-agent that referenced this pull request Feb 20, 2024
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants