Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Servicemontiors and Podlogs CRDs in grafana-agent helm chart #6220

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

balazs92117
Copy link

PR Description

The new grafana-agent flow helm chart can automatically install CRDs. But it includes only Podlogs. With this PR it will include Servicemonitors and Podmonitors CRDs too. Servicemonitors are widely used by a lot of helm charts, and the "flow version" of grafana-agent also supports it via prometheus.operator.servicemonitors

Which issue(s) this PR fixes

To use Servicemonitors in other helm charts, first I have to install that CRD. The grafana-agent helm chart already maintain a CRD, so it would be easier to include Servicemonitors CRD in it, so we don't have to install that CRD separately.

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Tests updated

The new flow version of grafna agent does not require these CRDs, but a lot of 3rd party chart already supports servicemonitors.
@CLAassistant
Copy link

CLAassistant commented Jan 23, 2024

CLA assistant check
All committers have signed the CLA.

@captncraig captncraig self-requested a review January 24, 2024 04:36
Copy link
Contributor

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@github-actions github-actions bot added the needs-attention An issue or PR has been sitting around and needs attention. label Feb 24, 2024
@rosariofe
Copy link

I encountered the same issue here, I'm migrating from Grafana Operator to Flow and when I tried to deploy for example kube-state-metrics and create the serviceMonitors related to them, I needed to install manually the CRDs from prometheus-operator to be able to scrape my personal serviceMonitor configuration.

@rfratto rfratto added variant/flow Relatd to Grafana Agent Flow. enhancement New feature or request labels Apr 9, 2024
@github-actions github-actions bot removed the needs-attention An issue or PR has been sitting around and needs attention. label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request variant/flow Relatd to Grafana Agent Flow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants