Rename prometheus.remote_write dashboard & add scrape metrics #6222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thampiotr
force-pushed
the
thampiotr/add-scrape-performance-to-dash
branch
from
3de9b8a
to
cfe229b
Compare
rfratto
reviewed
Jan 23, 2024
operations/agent-flow-mixin/dashboards/prometheus.remote_write.libsonnet
Outdated
Show resolved
Hide resolved
thampiotr
changed the title
thampiotr
force-pushed
the
thampiotr/add-scrape-performance-to-dash
branch
from
cf72d23
to
ab46a7b
Compare
thampiotr
force-pushed
the
thampiotr/add-scrape-performance-to-dash
branch
from
ab46a7b
to
2868750
Compare
rfratto
approved these changes
Jan 24, 2024
BarunKGP
pushed a commit
to BarunKGP/grafana-agent
that referenced
this pull request
Feb 20, 2024
…a#6222) * Add visibility of scrape performance to dashboards * Address feedback
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This adds visibility of scrape performance to our main Prometheus dashboard (currently called
prometheus.remote_write)We've agreed to have one dashboard per component namespace, with metrics of each component in separate collapsible rows on the dashboard. So also doing the following:
prometheus.remote_writedashboard to "Prometheus Components"Which issue(s) this PR fixes
(internal issue)
Notes to the Reviewer
This is a follow-up from an incident where scrape performance was badly affected, but it was hard to notice this using our dashboards.
During the incident, the query we're adding here would clearly highlight the issue:
PR Checklist