Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add task doc for Puppet #6240

Merged
merged 11 commits into from
Jan 31, 2024
Merged

Add task doc for Puppet #6240

merged 11 commits into from
Jan 31, 2024

Conversation

jcreixell
Copy link
Contributor

  - Adds basic instructions on how to install Grafana Agent using Puppet.
  - Fixes #5962
@jcreixell jcreixell added the type/docs Docs Squad label across all Grafana Labs repos label Jan 25, 2024
@jcreixell
Copy link
Contributor Author

tested with Fedora and Ubuntu, full module used for testing here: https://github.com/jcreixell/grafana-agent-puppet

Copy link
Contributor

@thampiotr thampiotr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

docs/sources/flow/get-started/install/puppet.md Outdated Show resolved Hide resolved
docs/sources/flow/get-started/install/puppet.md Outdated Show resolved Hide resolved
docs/sources/flow/get-started/install/puppet.md Outdated Show resolved Hide resolved
  - Set doc weight
  - Add missing aliases
  - Fix canonical url
  - Fix wording for puppet entities: A module contains manifests which
    contain classes which contain tasks.
Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor space suggestions

docs/sources/flow/get-started/install/puppet.md Outdated Show resolved Hide resolved
docs/sources/flow/get-started/install/puppet.md Outdated Show resolved Hide resolved
docs/sources/flow/get-started/install/puppet.md Outdated Show resolved Hide resolved
docs/sources/flow/get-started/install/puppet.md Outdated Show resolved Hide resolved
docs/sources/flow/get-started/install/puppet.md Outdated Show resolved Hide resolved
docs/sources/flow/get-started/install/puppet.md Outdated Show resolved Hide resolved
docs/sources/flow/get-started/install/puppet.md Outdated Show resolved Hide resolved
jcreixell and others added 8 commits January 31, 2024 17:55
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
@clayton-cornell
Copy link
Contributor

@jcreixell Merging. It looks good and if we need additional updates, we can pen a new PR.

@clayton-cornell clayton-cornell merged commit 3e1c17c into main Jan 31, 2024
10 checks passed
@clayton-cornell clayton-cornell deleted the puppet-install-docs branch January 31, 2024 18:39
BarunKGP pushed a commit to BarunKGP/grafana-agent that referenced this pull request Feb 20, 2024
* Add task doc for Puppet

  - Adds basic instructions on how to install Grafana Agent using Puppet.
  - Fixes grafana#5962

* Address feedback

  - Set doc weight
  - Add missing aliases
  - Fix canonical url
  - Fix wording for puppet entities: A module contains manifests which
    contain classes which contain tasks.

* Update docs/sources/flow/get-started/install/puppet.md

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>

* Update docs/sources/flow/get-started/install/puppet.md

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>

* Update docs/sources/flow/get-started/install/puppet.md

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>

* Update docs/sources/flow/get-started/install/puppet.md

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>

* Update docs/sources/flow/get-started/install/puppet.md

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>

* Update docs/sources/flow/get-started/install/puppet.md

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>

* Update puppet.md

---------

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Mar 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[task doc] installing agent using Puppet
3 participants