pyroscope.scrape: Adjust handling of scrape_timeout #6252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
force-pushed
the
20240126_adjust-timeout-when-blocking-collection
branch
from
097f236
to
5a57270
Compare
This automatically adapts the timeout when a ProfilingTarget is fetched with Delta=true. In those cases the HTTP calll is block for ScrapeInterval - 1s while the target profiles itself. This also updates the ScrapeTimeout to 10s (default in prometheus).
simonswine
force-pushed
the
20240126_adjust-timeout-when-blocking-collection
branch
from
5a57270
to
4f1f679
Compare
BarunKGP
pushed a commit
to BarunKGP/grafana-agent
that referenced
this pull request
Feb 20, 2024
* pyroscope.scrape: Adjust handling of scrape_timeout This automatically adapts the timeout when a ProfilingTarget is fetched with Delta=true. In those cases the HTTP calll is block for ScrapeInterval - 1s while the target profiles itself. This also updates the ScrapeTimeout to 10s (default in prometheus). * Adapt tests to the dynamic timeout * Fix linting problem
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This automatically adapts the timeout when a
ProfilingTargetis fetchedwith
Delta=true. In those cases the HTTP call is blocked forScrapeInterval - 1swhile the target profiles itself.This also updates the ScrapeTimeout to be 10s (default in prometheus).