Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong Y axis on new chart #6254

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Fix wrong Y axis on new chart #6254

merged 2 commits into from
Jan 26, 2024

Conversation

thampiotr
Copy link
Contributor

This is an unreleased feature, so no need to update the changelog.

  • The % Y axis used a fraction not multiplied by 100.
  • Added the in <cluster> to make it a bit more clear how the chart doesn't take into account other dash template variables from drop-downs.

image

@thampiotr thampiotr marked this pull request as ready for review January 26, 2024 14:31
@@ -19,7 +19,7 @@ local scrapePanels(y_offset) = [

// Scrape success rate
(
panel.new(title='Scrape success rate', type='timeseries') +
panel.new(title='Scrape success rate in $cluster', type='timeseries') +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL you could do this 😛

@thampiotr thampiotr merged commit 276db0a into main Jan 26, 2024
10 checks passed
@thampiotr thampiotr deleted the thampiotr/fix-chart-y-axis branch January 26, 2024 14:43
BarunKGP pushed a commit to BarunKGP/grafana-agent that referenced this pull request Feb 20, 2024
* Fix wrong Y axis on new chart

* use percentunit
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 26, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants