feat(loki/src/k8s): not restart tailers in loki.source.kubernetes component by above-average time deltas if K8s version is > 1.29.0
#6263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hainenber
changed the title
loki.source.kubernetes component by above-average time deltas if K8s version is >= 1.29.1loki.source.kubernetes component by above-average time deltas if K8s version is >= 1.29.0
hainenber
changed the title
loki.source.kubernetes component by above-average time deltas if K8s version is >= 1.29.0loki.source.kubernetes component by above-average time deltas if K8s version is > 1.29.0
rfratto
approved these changes
Mar 18, 2024
…omponent by above-average time deltas if K8s version is >= 1.29.1 Signed-off-by: hainenber <dotronghai96@gmail.com>
…g verbosity when fail to restart tailer Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
hainenber
force-pushed
the
not-restart-tailers-for-k8s-v1.29.1+
branch
from
50fc778
to
6abb1c3
Compare
|
I've resolved the merge conflict :D |
rfratto
added
variant/flow
Signed-off-by: Paschalis Tsilias <paschalist0@gmail.com>
tpaschalis
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Sorry that this one slipped through the cracks @hainenber! I've taken the liberty to fix merge conflicts so we can merge and cherry-pick over to the Alloy repo.
Again, thank you!
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Detect K8s version to decide whether to kick off goroutine to restart tailers by above-average deltas. Helps decreasing extraneous logs and might be a tiny bit of performance.
Which issue(s) this PR fixes
Fixes grafana/alloy#264
Notes to the Reviewer
PR Checklist