feat(run/flow): add metric to track counts of successful/failed config reloads #6303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g reloads Signed-off-by: hainenber <dotronghai96@gmail.com>
|
Is this too different from config_metrics.go? If we want some additional metrics, perhaps we could add them there? |
|
You're right, they're the same 😶🌫️. Thanks for the review, I'll close off this one |
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Which issue(s) this PR fixes
Implements grafana/alloy#304
Notes to the Reviewer
Should I mention these metrics in some sort of doc for discoverability? I'm thinking of
controller_metrics.mdbut not sure.PR Checklist