Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for proposed yaml_decode function #6315

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Documentation for proposed yaml_decode function #6315

wants to merge 5 commits into from

Conversation

djcode
Copy link
Contributor

@djcode djcode commented Feb 5, 2024

PR Description

This PR adds documentation for the yaml_decode function proposed in grafana/river#42

Notes to the Reviewer

This can only be merged when upstream has been merged.

PR Checklist

  • CHANGELOG.md updated
  • Documentation added

clayton-cornell
clayton-cornell approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

One minor suggestion... and it's fine to use the suggestion or leave it as-is.

@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Feb 6, 2024
djcode and others added 2 commits February 6, 2024 16:24
@djcode @clayton-cornell
Update docs/sources/flow/reference/stdlib/yaml_decode.md
8362224 
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
@clayton-cornell
Merge branch 'main' into yaml_decode_doc
de93380
@clayton-cornell
Copy link
Contributor

Looks good. Now we wait on grafana/river#42 to be completed :)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@github-actions github-actions bot added the needs-attention An issue or PR has been sitting around and needs attention. label Mar 8, 2024
@rfratto rfratto added the variant/flow Relatd to Grafana Agent Flow. label Apr 9, 2024
@github-actions github-actions bot removed the needs-attention An issue or PR has been sitting around and needs attention. label Apr 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@github-actions github-actions bot added the needs-attention An issue or PR has been sitting around and needs attention. label May 19, 2024
@clayton-cornell
Copy link
Contributor

@mattdurham What should we do with this PR? It depended on grafana/river#42 but it looks like things have moved (will move?) over to Alloy?

@mattdurham
Copy link
Collaborator

I think we can close this PR since this wont get backported to agent. @djcode thoughts?

@github-actions github-actions bot removed the needs-attention An issue or PR has been sitting around and needs attention. label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayton-cornell clayton-cornell clayton-cornell approved these changes

Assignees
No one assigned
Labels
type/docs Docs Squad label across all Grafana Labs repos variant/flow Relatd to Grafana Agent Flow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@djcode @clayton-cornell @mattdurham @rfratto