Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention stage.pack in the stage.timestamp docs. #6371

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Mention stage.pack in the stage.timestamp docs. #6371

merged 1 commit into from
Feb 16, 2024

Conversation

ptodev
Copy link
Contributor

@ptodev ptodev commented Feb 15, 2024

This was a source of confusion (#4337) and took a while to identify. It's not very obvious...

clayton-cornell
clayton-cornell approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@clayton-cornell clayton-cornell left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - does this need to be backported?

@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Feb 15, 2024
@ptodev
Copy link
Contributor Author

ptodev commented Feb 16, 2024

LGTM - does this need to be backported?

@clayton-cornell Yeah, let's backport it to v0.38 and v0.39

@clayton-cornell clayton-cornell merged commit f140df7 into main Feb 16, 2024
13 checks passed
@clayton-cornell clayton-cornell deleted the ptodev/docs-clarify-timestamp branch February 16, 2024 13:03
grafanabot pushed a commit that referenced this pull request Feb 16, 2024
@ptodev @grafanabot
Mention stage.pack in the stage.timestamp docs. (#6371)
41a127c 
(cherry picked from commit f140df7)
@grafanabot grafanabot mentioned this pull request Feb 16, 2024
Merged
grafanabot pushed a commit that referenced this pull request Feb 16, 2024
@ptodev @grafanabot
Mention stage.pack in the stage.timestamp docs. (#6371)
4726ee6 
(cherry picked from commit f140df7)
@grafanabot grafanabot mentioned this pull request Feb 16, 2024
Merged
clayton-cornell pushed a commit that referenced this pull request Feb 16, 2024
@grafanabot @ptodev
Mention stage.pack in the stage.timestamp docs. (#6371) (#6376)
240c3b0 
(cherry picked from commit f140df7)

Co-authored-by: Paulin Todev <paulin.todev@gmail.com>
clayton-cornell pushed a commit that referenced this pull request Feb 16, 2024
@grafanabot @ptodev
Mention stage.pack in the stage.timestamp docs. (#6371) (#6377)
efa54af 
(cherry picked from commit f140df7)

Co-authored-by: Paulin Todev <paulin.todev@gmail.com>
BarunKGP pushed a commit to BarunKGP/grafana-agent that referenced this pull request Feb 20, 2024
@ptodev @BarunKGP
Mention stage.pack in the stage.timestamp docs. (grafana#6371)
23e17dc
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Mar 18, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clayton-cornell clayton-cornell clayton-cornell approved these changes

Assignees
No one assigned
Labels
backport release-v0.38 backport release-v0.39 frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ptodev @clayton-cornell